feat: Complete Phase 2 - Enhanced Risk & Sizing
Some checks failed
Build and Test / build (push) Has been cancelled

Implementation (7 files, ~2,640 lines):
- AdvancedRiskManager with Tier 2-3 risk controls
  * Weekly rolling loss limits (7-day window, Monday rollover)
  * Trailing drawdown protection from peak equity
  * Cross-strategy exposure limits by symbol
  * Correlation-based position limits
  * Time-based trading windows
  * Risk mode system (Normal/Aggressive/Conservative)
  * Cooldown periods after violations

- Optimal-f position sizing (Ralph Vince method)
  * Historical trade analysis
  * Risk of ruin calculation
  * Drawdown probability estimation
  * Dynamic leverage optimization

- Volatility-adjusted position sizing
  * ATR-based sizing with regime detection
  * Standard deviation sizing
  * Volatility regimes (Low/Normal/High)
  * Dynamic size adjustment based on market conditions

- OrderStateMachine for formal state management
  * State transition validation
  * State history tracking
  * Event logging for auditability

Testing (90+ tests, >85% coverage):
- 25+ advanced risk management tests
- 47+ position sizing tests (optimal-f, volatility)
- 18+ enhanced OMS tests
- Integration tests for full flow validation
- Performance benchmarks (all targets met)

Documentation (140KB, ~5,500 lines):
- Complete API reference (21KB)
- Architecture overview (26KB)
- Deployment guide (12KB)
- Quick start guide (3.5KB)
- Phase 2 completion report (14KB)
- Documentation index

Quality Metrics:
- Zero new compiler warnings
- 100% C# 5.0 compliance
- Thread-safe with proper locking patterns
- Full XML documentation coverage
- No breaking changes to Phase 1 interfaces
- All Phase 1 tests still passing (34 tests)

Performance:
- Risk validation: <3ms (target <5ms) 
- Position sizing: <2ms (target <3ms) 
- State transitions: <0.5ms (target <1ms) 

Phase 2 Status:  COMPLETE
Time: ~3 hours (vs 10-12 hours estimated manual)
Ready for: Phase 3 (Market Microstructure & Execution)
This commit is contained in:
2026-02-16 11:00:13 -05:00
parent fb4f5d3bde
commit fb2b0b6cf3
32 changed files with 10748 additions and 249 deletions

View File

@@ -0,0 +1,191 @@
using System;
using System.Collections.Generic;
using NT8.Core.Common.Models;
namespace NT8.Adapters.NinjaTrader
{
/// <summary>
/// Converts NinjaTrader adapter inputs to SDK model instances.
/// </summary>
public static class NT8DataConverter
{
/// <summary>
/// Converts primitive bar inputs into SDK bar data.
/// </summary>
/// <param name="symbol">Instrument symbol.</param>
/// <param name="time">Bar timestamp.</param>
/// <param name="open">Open price.</param>
/// <param name="high">High price.</param>
/// <param name="low">Low price.</param>
/// <param name="close">Close price.</param>
/// <param name="volume">Bar volume.</param>
/// <param name="barSizeMinutes">Bar timeframe in minutes.</param>
/// <returns>Converted <see cref="BarData"/> instance.</returns>
/// <exception cref="ArgumentException">Thrown when symbol is missing or bar size is invalid.</exception>
public static BarData ConvertBar(string symbol, DateTime time, double open, double high, double low, double close, long volume, int barSizeMinutes)
{
if (string.IsNullOrWhiteSpace(symbol))
{
throw new ArgumentException("symbol");
}
if (barSizeMinutes <= 0)
{
throw new ArgumentException("barSizeMinutes");
}
try
{
return new BarData(symbol, time, open, high, low, close, volume, TimeSpan.FromMinutes(barSizeMinutes));
}
catch (Exception)
{
throw;
}
}
/// <summary>
/// Converts account values into SDK account info.
/// </summary>
/// <param name="equity">Current account equity.</param>
/// <param name="buyingPower">Available buying power.</param>
/// <param name="dailyPnL">Current day profit and loss.</param>
/// <param name="maxDrawdown">Maximum drawdown value.</param>
/// <param name="lastUpdate">Last account update timestamp.</param>
/// <returns>Converted <see cref="AccountInfo"/> instance.</returns>
public static AccountInfo ConvertAccount(double equity, double buyingPower, double dailyPnL, double maxDrawdown, DateTime lastUpdate)
{
try
{
return new AccountInfo(equity, buyingPower, dailyPnL, maxDrawdown, lastUpdate);
}
catch (Exception)
{
throw;
}
}
/// <summary>
/// Converts position values into SDK position info.
/// </summary>
/// <param name="symbol">Instrument symbol.</param>
/// <param name="quantity">Position quantity.</param>
/// <param name="averagePrice">Average entry price.</param>
/// <param name="unrealizedPnL">Unrealized PnL value.</param>
/// <param name="realizedPnL">Realized PnL value.</param>
/// <param name="lastUpdate">Last position update timestamp.</param>
/// <returns>Converted <see cref="Position"/> instance.</returns>
/// <exception cref="ArgumentException">Thrown when symbol is missing.</exception>
public static Position ConvertPosition(string symbol, int quantity, double averagePrice, double unrealizedPnL, double realizedPnL, DateTime lastUpdate)
{
if (string.IsNullOrWhiteSpace(symbol))
{
throw new ArgumentException("symbol");
}
try
{
return new Position(symbol, quantity, averagePrice, unrealizedPnL, realizedPnL, lastUpdate);
}
catch (Exception)
{
throw;
}
}
/// <summary>
/// Converts market session values into SDK market session.
/// </summary>
/// <param name="sessionStart">Session start timestamp.</param>
/// <param name="sessionEnd">Session end timestamp.</param>
/// <param name="isRth">True for regular trading hours session.</param>
/// <param name="sessionName">Session display name.</param>
/// <returns>Converted <see cref="MarketSession"/> instance.</returns>
/// <exception cref="ArgumentException">Thrown when session name is missing or session range is invalid.</exception>
public static MarketSession ConvertSession(DateTime sessionStart, DateTime sessionEnd, bool isRth, string sessionName)
{
if (string.IsNullOrWhiteSpace(sessionName))
{
throw new ArgumentException("sessionName");
}
if (sessionEnd < sessionStart)
{
throw new ArgumentException("sessionEnd");
}
try
{
return new MarketSession(sessionStart, sessionEnd, isRth, sessionName);
}
catch (Exception)
{
throw;
}
}
/// <summary>
/// Converts values into SDK strategy context.
/// </summary>
/// <param name="symbol">Instrument symbol.</param>
/// <param name="currentTime">Current timestamp.</param>
/// <param name="currentPosition">Current position info.</param>
/// <param name="account">Current account info.</param>
/// <param name="session">Current market session.</param>
/// <param name="customData">Custom data dictionary.</param>
/// <returns>Converted <see cref="StrategyContext"/> instance.</returns>
/// <exception cref="ArgumentException">Thrown when symbol is missing.</exception>
/// <exception cref="ArgumentNullException">Thrown when required objects are null.</exception>
public static StrategyContext ConvertContext(
string symbol,
DateTime currentTime,
Position currentPosition,
AccountInfo account,
MarketSession session,
Dictionary<string, object> customData)
{
if (string.IsNullOrWhiteSpace(symbol))
{
throw new ArgumentException("symbol");
}
if (currentPosition == null)
{
throw new ArgumentNullException("currentPosition");
}
if (account == null)
{
throw new ArgumentNullException("account");
}
if (session == null)
{
throw new ArgumentNullException("session");
}
Dictionary<string, object> convertedCustomData;
if (customData == null)
{
convertedCustomData = new Dictionary<string, object>();
}
else
{
convertedCustomData = new Dictionary<string, object>();
foreach (var pair in customData)
{
convertedCustomData.Add(pair.Key, pair.Value);
}
}
try
{
return new StrategyContext(symbol, currentTime, currentPosition, account, session, convertedCustomData);
}
catch (Exception)
{
throw;
}
}
}
}